[Akka.NET v1.5.15 upgrade] introduced AK1001 bug (#150)

* introduced `AK1001` bug * upgraded to Akka.NET v1.5.15
petabridge · Jan 10, 2024 · 9eec062 · 9eec062
1 parent 4cb76c7
commit 9eec062
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -16,9 +16,9 @@
     <NetRuntime>net6.0</NetRuntime>
     <XunitVersion>2.4.2</XunitVersion>
     <TestSdkVersion>17.6.0</TestSdkVersion>
-    <AkkaVersion>1.5.7</AkkaVersion>
-    <PbmVersion>1.3.1</PbmVersion>
-    <AkkaHostingVersion>1.5.5</AkkaHostingVersion>
+    <AkkaVersion>1.5.15</AkkaVersion>
+    <PbmVersion>1.3.2</PbmVersion>
+    <AkkaHostingVersion>1.5.15</AkkaHostingVersion>
     <MicrosoftExtensionsVersion>[7.0.0,)</MicrosoftExtensionsVersion>
   </PropertyGroup>
   <!-- SourceLink support for all Akka.NET projects -->

diff --git a/src/clustering/sharding-sqlserver/SqlSharding.Host/Actors/ProductTotalsActor.cs b/src/clustering/sharding-sqlserver/SqlSharding.Host/Actors/ProductTotalsActor.cs
@@ -49,8 +49,6 @@ public ProductTotalsActor(string persistenceId)
             var response = State.ProcessCommand(cmd);
             var sentResponse = false;
 
-            var sender = Sender;
-
             if (response.ResponseEvents.Any())
             {
                 PersistAll(response.ResponseEvents, productEvent =>
@@ -66,7 +64,15 @@ public ProductTotalsActor(string persistenceId)
                     if (!sentResponse) // otherwise we'll generate a response-per-event
                     {
                         sentResponse = true;
-                        sender.Tell(response);
+
+                        async Task<ProductCommandResponse> ReplyToSender()
+                        {
+                            await Task.Delay(1);
+                            return response;
+                        }
+                        var sender = Sender;
+                        ReplyToSender().PipeTo(sender, failure: ex => new Status.Failure(ex));
+
                     }
 
                     if(LastSequenceNr % 10 == 0)

diff --git a/src/clustering/sharding-sqlserver/SqlSharding.Shared/Sharding/ProductMessageRouter.cs b/src/clustering/sharding-sqlserver/SqlSharding.Shared/Sharding/ProductMessageRouter.cs
@@ -15,10 +15,6 @@ public sealed class ProductMessageRouter : HashCodeMessageExtractor
             return productId.ProductId;
         }
 
-        // need this for remember-entities
-        if (message is ShardRegion.StartEntity se)
-            return se.EntityId;
-
         return null;
     }
 }