update demo and remove sandbox instance #5
Merged
+9
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Augustin Husson <[email protected]>
Nexucis
force-pushed
the
nexucis/update-demo
branch
from
4bd42d7 to
833f420
Compare
| @@ -26,29 +27,6 @@ services: | |||
| - "traefik.http.routers.demo.rule=Host(`demo.perses.dev`)" | |||
| - "traefik.http.routers.demo.tls.certresolver=myresolver" | |||
|
|
|||
| sandbox: | |||
There was a problem hiding this comment.
Are you sure about removing it? Seems not much people played with this sandbox instance so far, but I think it's good for people new to Perses to be able to try it in edit mode without having to install it by themselves.
There was a problem hiding this comment.
With permissions, demo instance will not be readonly anymore, so sandbox can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.