use the distroless image for development with a cluster #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nexucis
reviewed
Dec 20, 2024
| COPY --chown=nobody:nobody LICENSE /LICENSE | ||
| COPY --from=build-env --chown=nobody:nobody /etc/mime.types /etc/mime.types | ||
|
|
||
| EXPOSE 8080 | ||
| ENTRYPOINT [ "/bin/operator" ] | ||
| ENTRYPOINT [ "/bin/manager" ] |
There was a problem hiding this comment.
the location of the binary shouldn't be at root ? /manager (Based on the previous issue #38 )
There was a problem hiding this comment.
The deployment was using a command to point to the /manager but I removed it so it uses the default image entrypoint . Which for consistency is now /bin/manager
|
@jgbernalp to fix the CI, you need to update the file https://github.com/perses/perses-operator/blob/main/scripts/generate-goreleaser/.goreleaser.base.yaml#L5 to update the binary there |
Signed-off-by: Gabriel Bernal <[email protected]>
jgbernalp
force-pushed
the
use-distroless-for-local-setup
branch
from
ffef9ea to
856c76c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the binary name in the distroless images. Also adjusts the metrics default port to avoid collisions while testing locally, fixes: #40