[CHORE] enhancing dashboard usage #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolastakashi
force-pushed
the
chore/enhance-dashboard-usage
branch
from
04385a6 to
9338d04
Compare
nicolastakashi
changed the title
Nexucis
reviewed
Nov 27, 2024
Nexucis
reviewed
Nov 27, 2024
nicolastakashi
force-pushed
the
chore/enhance-dashboard-usage
branch
from
9338d04 to
7609a52
Compare
Nexucis
reviewed
Nov 27, 2024
nicolastakashi
force-pushed
the
chore/enhance-dashboard-usage
branch
from
f5d246d to
26b0d88
Compare
Signed-off-by: Nicolas Takashi <[email protected]>
nicolastakashi
force-pushed
the
chore/enhance-dashboard-usage
branch
from
26b0d88 to
169593d
Compare
Nexucis
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the handling of dashboard usage information in the metric usage data structure. The most important changes involve adding a new
DashboardUsagetype and updating theMetricUsagestructure to use this new type.Improvements to data structures:
pkg/api/v1/metric_usage.go: Added a newDashboardUsagetype with fields forUID,Name, andURL. Updated theMetricUsagestructure to use a set ofDashboardUsageinstead of a set of strings for dashboards.Updates to usage generation functions:
source/grafana/grafana.go: Modified thegenerateUsagefunction to create and addDashboardUsageobjects instead of just URLs for Grafana dashboards.source/perses/perses.go: Modified thegenerateUsagefunction to create and addDashboardUsageobjects instead of just URLs for Perses dashboards.