[BUGFIX] Ingress configuration values and schema #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes kubernetes checks for versions that are end-of-life since long ago Signed-off-by: André Falk <[email protected]>
Signed-off-by: André Falk <[email protected]>
kryachkov
requested review from
celian-garcia,
nicolastakashi and
Nexucis
as code owners
|
Hey @kryachkov thanks for working on that, just left some questions. |
|
I guess we are good to merge right @nicolastakashi ? |
Yes, sorry! Thanks for your PR @kryachkov |
nicolastakashi
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #38 and as a bonus removes kubernetes version checks in ingress manifest template (versions being checked against are end-of-life since years ago)
Checklist
[<catalog_entry>] <commit message>naming convention using one of the followingcatalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,IGNORE.