[ENHANCEMENT] Add global property to schema to enable Perses as a dependent Chart #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
ibakshay
requested review from
celian-garcia,
nicolastakashi and
Nexucis
as code owners
nicolastakashi
approved these changes
Nov 14, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the
globalproperty to the schema to enable using the chart as a Dependent Chart. This addresses a known Helm limitation (helm/helm#10392) that prevents charts from being used as dependent charts when the global property is not defined in thevalues.schema.json.Error encountered in our perses wrapper chart:
Changes: