[ENHANCEMENT] deprecate datasources configuration

Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
perses · Nov 8, 2024 · 97ac588 · 97ac588
1 parent 3389d64
commit 97ac588
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 2 deletions.
diff --git a/charts/perses/Chart.yaml b/charts/perses/Chart.yaml
@@ -3,7 +3,7 @@ name: perses
 description: Perses helm chart
 icon: https://avatars.githubusercontent.com/u/77209215?s=200&v=4
 type: application
-version: 0.7.0
+version: 0.7.1
 appVersion: "v0.49.0"
 sources:
   - https://github.com/perses/perses

diff --git a/charts/perses/templates/NOTES.txt b/charts/perses/templates/NOTES.txt
@@ -5,3 +5,14 @@
 {{- if and .Values.persistence.enabled (eq .Values.persistence.storageClass "") }}
 {{ fail "[ERROR] 'persistencen.storageClass' must be set." }}
 {{ end }}
+
+{{- if .Values.datasources }}
+{{- if not (empty .Values.datasources) }}
+#################################################################################
+######   WARNING: The 'datasources' configuration field is deprecated       #####
+######            and will be removed in the future version.                #####
+######            Please migrate to using the 'sidecar' configuration       #####
+######            for provisioning datasources.                             #####
+#################################################################################
+{{- end }}
+{{- end }}
diff --git a/charts/perses/templates/statefulset.yaml b/charts/perses/templates/statefulset.yaml
@@ -64,6 +64,12 @@ spec:
           - name: data
             mountPath: {{ .Values.config.database.file.folder }}
           {{- end }}
+          {{- if .Values.datasources }}
+          {{- if not (empty .Values.datasources) }}
+          - name: datasources
+            mountPath: /etc/perses/datasources
+          {{- end }}
+          {{- end }}
           {{- if .Values.sidecar.enabled }}
           - name: provisioning
             mountPath: {{ .Values.config.provisioning.folders | first }}
@@ -111,6 +117,13 @@ spec:
         - name: config
           configMap:
             name: {{ include "perses.fullname" . }}
+        {{- if .Values.datasources }}
+        {{- if not (empty .Values.datasources) }}
+        - name: datasources
+          configMap:
+            name: {{ include "perses.fullname" . }}-datasources
+        {{- end }}
+        {{- end }}
         {{- if .Values.sidecar.enabled }}
         - name: provisioning
           emptyDir: {}

diff --git a/charts/perses/values.schema.json b/charts/perses/values.schema.json
@@ -88,7 +88,9 @@
       "type": "object"
     },
     "datasources": {
-      "type": "array"
+      "type": "array",
+      "deprecated": true,
+      "description": "DEPRECATED: This field will be removed in the future release. Please use the 'sidecar' configuration instead to load datasources"
     },
     "config": {
       "type": "object",

diff --git a/charts/perses/values.yaml b/charts/perses/values.yaml
@@ -216,6 +216,7 @@ ingress:
 #      hosts: []
 
 # -- Configure datasources
+# DEPRECATED: This field will be removed in the future release. Please use the 'sidecar' configuration to provision datasources.
 # ref: https://github.com/perses/perses/blob/90beed356243208f14cf2249bebb6f6222cb77ae/docs/datasource.md
 datasources:
   []