Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore deprecated properties to run.json schema #571

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

k-rister
Copy link
Contributor

  • even though these properties are no longer used they ar necessary for processing/indexing existing data

@k-rister k-rister added bug Something isn't working DO NOT MERGE labels Nov 24, 2024
@k-rister k-rister requested a review from HughNhan November 24, 2024 15:24
@k-rister k-rister self-assigned this Nov 24, 2024
@k-rister
Copy link
Contributor Author

@HughNhan Can you confirm that this patch fixes your indexing problem?

- even though these properties are no longer used they ar necessary
  for processing/indexing existing data
@k-rister
Copy link
Contributor Author

Assuming that this passes CI (I just had to make a typo bugfix), if @HughNhan says it's good for him then the DO NOT MERGE label no longer applies.

@HughNhan
Copy link
Contributor

It works. I can index the problematic run that the previous attempt before the fix would error out.

Copy link
Contributor

@HughNhan HughNhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Work great for me (WGFM)

@k-rister k-rister merged commit 7e69a57 into master Nov 25, 2024
150 checks passed
@k-rister k-rister deleted the dev-kmr branch November 25, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants