Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support cdmv8 #567

Merged
merged 3 commits into from
Nov 14, 2024
Merged

support cdmv8 #567

merged 3 commits into from
Nov 14, 2024

Conversation

atheurer
Copy link
Contributor

  • with backward compat with cdmv7
  • cdmv8 will be introduced via CommonDataModel after this PR

- with backward compat with cdmv7
@atheurer atheurer requested a review from k-rister November 10, 2024 15:29
@atheurer atheurer self-assigned this Nov 10, 2024
Copy link
Contributor

@k-rister k-rister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is broken, massive CI failures.

- assign cdm version earlier
- fix period persisten id field name
@atheurer atheurer requested a review from k-rister November 12, 2024 10:51
rickshaw-index Outdated Show resolved Hide resolved
rickshaw-index Outdated Show resolved Hide resolved
rickshaw-index Outdated Show resolved Hide resolved
@atheurer atheurer requested a review from k-rister November 13, 2024 18:41
@atheurer atheurer merged commit de96d6e into master Nov 14, 2024
148 of 150 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants