Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculating begin/end needed further refinement #563

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Calculating begin/end needed further refinement #563

merged 1 commit into from
Nov 1, 2024

Conversation

atheurer
Copy link
Contributor

  • See code comments for details

@atheurer atheurer self-assigned this Oct 31, 2024
@atheurer atheurer requested a review from k-rister October 31, 2024 12:05
k-rister
k-rister approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@k-rister k-rister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I have one curiosity, why are we only finding these problems now? What is different about what you are doing?

@k-rister k-rister force-pushed the index-metrics-begin-end branch from 81582e7 to 2ef1045 Compare October 31, 2024 14:00
@atheurer atheurer merged commit 5fa0e9e into master Nov 1, 2024
150 checks passed
@k-rister k-rister deleted the index-metrics-begin-end branch November 1, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-rister k-rister k-rister approved these changes

Assignees

@atheurer atheurer

Labels
None yet
Projects
Crucible Tracking
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atheurer @k-rister