Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profilers should never use benchmark pod settings #558

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Profilers should never use benchmark pod settings #558

merged 1 commit into from
Oct 25, 2024

Conversation

atheurer
Copy link
Contributor

  • profiler (tools) pods should not use the user's preferences for benchmark pods. For example, we don't want benchmark-specific mounts, pass-through devices, etc.

@atheurer
Profilers should never use benchmark pod settings
a940990 
- profiler (tools) pods should not use the user's
  preferences for benchmark pods.  For example, we
  don't want benchmark-specific mounts, pass-through
  devices, etc.
@atheurer atheurer requested a review from k-rister October 24, 2024 17:56
@k-rister k-rister merged commit a3ca520 into master Oct 25, 2024
151 checks passed
@k-rister k-rister deleted the profiler-no-podman-settings branch October 25, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-rister k-rister k-rister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Crucible Tracking
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atheurer @k-rister