Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev kmr2 #510

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Dev kmr2 #510

merged 2 commits into from
Jul 15, 2024

Conversation

k-rister
Copy link
Contributor

No description provided.

k-rister added 2 commits July 11, 2024 16:55
…riable image expiration

- when possible use the current expiration values from the quay
  repository by retreiving them using the quay API

- when the quay repository cannot be accessed via the quay API, use
  the expiration settings from rickshaw-settings.json instead of it
  being hard coded at 2 weeks
- I think this is just a better way of running the query since it
  purposefully avoids the possibility of returning a stale (inactive)
  tag
Copy link
Contributor

@rafaelfolco rafaelfolco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, questions raised

endpoints/remotehosts/remotehosts.py Show resolved Hide resolved
endpoints/remotehosts/remotehosts.py Show resolved Hide resolved
@k-rister k-rister merged commit 47250af into master Jul 15, 2024
186 checks passed
@k-rister k-rister deleted the dev-kmr2 branch July 15, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants