Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract all shared/reusable code from remotehosts.py and create endpo… #498

Merged
merged 1 commit into from
May 28, 2024

Conversation

k-rister
Copy link
Contributor

…ints.py containing it

@k-rister k-rister added the enhancement New feature or request label May 22, 2024
@k-rister k-rister requested a review from a team May 22, 2024 21:25
@k-rister k-rister self-assigned this May 22, 2024
rafaelfolco
rafaelfolco previously approved these changes May 23, 2024
Copy link
Contributor

@rafaelfolco rafaelfolco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for a quick pass - few comments on code style

endpoints/endpoints.py Show resolved Hide resolved
endpoints/endpoints.py Show resolved Hide resolved
endpoints/endpoints.py Show resolved Hide resolved
endpoints/endpoints.py Outdated Show resolved Hide resolved
endpoints/endpoints.py Outdated Show resolved Hide resolved
Copy link
Contributor

@rafaelfolco rafaelfolco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

superficial review, lgtm

endpoints/endpoints.py Show resolved Hide resolved
endpoints/endpoints.py Show resolved Hide resolved
endpoints/endpoints.py Show resolved Hide resolved
endpoints/endpoints.py Show resolved Hide resolved
endpoints/endpoints.py Show resolved Hide resolved
endpoints/endpoints.py Show resolved Hide resolved
endpoints/endpoints.py Show resolved Hide resolved
endpoints/endpoints.py Show resolved Hide resolved
@k-rister k-rister merged commit c2cf489 into master May 28, 2024
204 checks passed
@k-rister k-rister deleted the dev-kmr branch May 28, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants