Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev kmr4 #486

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Dev kmr4 #486

merged 2 commits into from
Apr 23, 2024

Conversation

k-rister
Copy link
Contributor

No description provided.

…f the endpoint stream

- apparently, we have been relying on the endpoint type being
  processed as the first property of the object which has somehow
  magically worked up until this point

- when the run-file is created by something like the new
  ci-run-file-creator.py script then the properties are sorted
  alphabetically and the type is not first which breaks processing
@k-rister
Copy link
Contributor Author

@rafaelfolco

It's probably going to be hard to read/understand this, but the code in this PR will be "turned on" by a subsequent PR in crucible-ci that uses it. That PR will be based on this work:

perftool-incubator/crucible-ci@main...k-rister:crucible-ci:dev-kmr

Copy link
Contributor

@rafaelfolco rafaelfolco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean code, very nice :)

@k-rister k-rister merged commit 4ee243e into master Apr 23, 2024
138 checks passed
@k-rister k-rister deleted the dev-kmr4 branch April 23, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants