check cdmver before getting period

[atheurer]

No description provided.

[k-rister]

@atheurer it just occurred to me that this is determining what the CDM version is by looking at the CDM repo, but that is somewhat irrelevant to what the result directory it is looking at is version wise. I took a quick glance and I don't see anything in a postprocessed run directory that indicates what CDM version it adheres to -- shouldn't that be something that is included as part of the documents?

[k-rister]

@atheurer To be clear, this PR should allow your existing v8dev PR to pass CI, but I'm wondering if we should also include embedding of the CDM version in the documents as part of the new v8dev changes.

[atheurer]

@atheurer To be clear, this PR should allow your existing v8dev PR to pass CI, but I'm wondering if we should also include embedding of the CDM version in the documents as part of the new v8dev changes.

Yes, I was thinking about this, too. I do think we need to embed the version in the docs, but I wanted to make that a different effort if possible. We probably need to pull the logic from rickshaw-index that finds the actual cdm version present in the indices and put that in toolbox or maybe just a script in CDM.

[k-rister]

@atheurer To be clear, this PR should allow your existing v8dev PR to pass CI, but I'm wondering if we should also include embedding of the CDM version in the documents as part of the new v8dev changes.

Yes, I was thinking about this, too. I do think we need to embed the version in the docs, but I wanted to make that a different effort if possible. We probably need to pull the logic from rickshaw-index that finds the actual cdm version present in the indices and put that in toolbox or maybe just a script in CDM.

I guess that poses an interesting question, does making it part of a different effort mean that it is part of a newer version (v9dev)? It seems like unless we make the changes in an atomic fashion that each change means a new version, and switching versions seems to be annoying at best. But if you are comfortable with that then I'm fine with it.