Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spec file detailing plans for a registries.json config file #388

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

k-rister
Copy link
Contributor

No description provided.

@k-rister
Copy link
Contributor Author

Let's merge a different PR first: #384

In order to avoid useless CI re-runs...this PR just runs the faux jobs so it can be rebased and pass CI again really easily.

Copy link
Contributor

@atheurer atheurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does /etc/sysconfig/crucible need to have a line to point to the registries.json?

@k-rister
Copy link
Contributor Author

Does /etc/sysconfig/crucible need to have a line to point to the registries.json?

I think something that we need to decide is where this file should be located and that would determine if it needs a pointer in /etc/sysconfig/crucible.

We could place it in ~/.crucible and then we would be able find it automatically.

We could place it "out of tree" somewhere else and then probably we would have to have a pointer in /etc/sysconfig/crucible.

We could also place it "in tree" and be able to find it very easily, but that might come with some fast forward/merge problems if/when we need to make changes/additions to the file down the road. Since this file will be full of "local" data and only the basic structure would be known/controlled by upstream I'm not sure that "in tree" makes sense -- it might end up being more trouble than it's worth.

@k-rister k-rister marked this pull request as ready for review August 21, 2024 14:44
@k-rister k-rister added rhel-ai public/private Handle public/private repos labels Aug 21, 2024
@k-rister k-rister merged commit 020914f into master Aug 21, 2024
2 checks passed
@k-rister k-rister deleted the dev-kmr branch August 21, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
public/private Handle public/private repos rhel-ai
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants