Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional "crucible log" command tests to the integration-tests … #149

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

k-rister
Copy link
Contributor

…action

@k-rister k-rister requested a review from a team October 22, 2024 14:49
@k-rister k-rister self-assigned this Oct 22, 2024
Copy link
Contributor

@rafaelfolco rafaelfolco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderign what "force" means

@k-rister
Copy link
Contributor Author

wonderign what "force" means

Part of what the run_cmd does is that by default it will only run the command if the job is still passing -- so if a job fails then future run_cmd invocations will skip running the command in order to "optimize" the runtime. The "force" parameter is used to modify that behavior and commands that have "force" set will run anyway. Commands that are short running and/or potentially useful for debugging purposes have "force" set so that they will always execute no matter what has previously happened.

The most obvious use case for "force" not being present is when there are multiple run commands present. If the first run command fails then skipping subsequent run commands can significantly reduce the runtime of the job.

Also, when "force" is set the logged commands will note that they were forced:

image

Which can be helpful in noticing where the actual failure happened. In this case you can work backwards from the first "forced" line (983) and find that the run command on line 795 is where the actual failure occured (lines 976, 978, and 981 are just logging entries and not run_cmd invocations:

image

@k-rister k-rister merged commit ae0704a into main Oct 23, 2024
455 checks passed
@k-rister k-rister deleted the dev-kmr branch October 23, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants