Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous bugfixs from release #155

Merged
merged 10 commits into from
Aug 13, 2024
Merged

Miscellaneous bugfixs from release #155

merged 10 commits into from
Aug 13, 2024

Conversation

harjain99
Copy link
Contributor

  • Fixes subnet creation
    • Networks were created with a default subnet covering the entire network range if one wasn't provided
    • this made it impossible to create other subnets
    • the fix was to specify subnets in the network creation call
  • The enableMultipleStandardLoadBalancers in the K8s cluster network profile was getting a default value set, which is no longer supported by the api.
  • Fixes public container creation
    • There is a delay for the StorageAccount to actually become public.
    • Unfortunately the api doesn't really provide a good way to determine if the account is actually public.
    • The fix was to add a wait/retry on the container creation call which results in a 409 error if the creation isn't successful

@tloisel1
Copy link
Member

Code review looks okay

Copy link
Contributor

@deepanjan90 deepanjan90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One inline comment

@harjain99 harjain99 requested a review from deepanjan90 August 13, 2024 20:10
@deepanjan90 deepanjan90 merged commit 37d1eba into master Aug 13, 2024
1 check passed
@deepanjan90 deepanjan90 deleted the bugfix/release-bugs branch August 13, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants