Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple client types for base implementations #149

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

harjain99
Copy link
Contributor

@harjain99 harjain99 commented Jul 31, 2024

Support multiple clients for base azure resource, credentials and finder implementations.

The base azure implementations (AzureResource, AzureFinder and AzureCredentials) currently only support a single client type (AzureResourceManager).
With the introduction of a new client type (CommunicationManager) we need a way to generalize extending the AzureResource and AzureFinder models, which can support multiple clients (See gyro-aws-provider).

This PR:

  • Updates every createClient call to specify the client class (similar to gyro-aws-provider)
  • Provides a generic way of creating clients and extending the Finder implementation where you can specify the client type that resource will depend on.

... for base azure resource, credentials and finder implementations
Copy link
Member

@tloisel1 tloisel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This touches a lot of files, which is not bad in itself.

What we need is an explanation of the problem, the strategy of the solution, and the implementation details of that solution.

In other words, we need an explanation that somebody without in depth knowledge of the code base can understand, and give context to the code changes.

@harjain99
Copy link
Contributor Author

Update the description @tloisel1

@deepanjan90 deepanjan90 merged commit e54d575 into master Aug 1, 2024
1 check passed
@deepanjan90 deepanjan90 deleted the feature/support-multiple-clients branch August 1, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants