Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make aws client creation parameters configurable #453

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

deepanjan90
Copy link
Contributor

@deepanjan90 deepanjan90 commented Apr 26, 2021

Fixes: #436

example custom config that is the default config as well

@aws::client-configuration 'default'
    override-configuration
        retry-policy
            count: 20

            capacity-retry-condition
                retry-on-throttling-condition

                end
            end
        end
    end
@end

More info part of the readme https://github.com/perfectsense/gyro-aws-provider/blob/feature/client-configuration/src/main/java/gyro/aws/clientconfiguration/README.MD

 - This will let aws credentials be associated with client configs.
 - Will enable to use client configs when using @uses-credentials
Validation can now point to particular location of error
 - Remove duplication by introducing abstract classes with common code.
 - Update error handling to handle error which are parent specific.
 - TokenBucketRetryCondition
 - RetryOnClockSkewCondition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make aws client creation parameters configurable
1 participant