Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Secrets #304

Open
wants to merge 66 commits into
base: master
Choose a base branch
from
Open

Implement Secrets #304

wants to merge 66 commits into from

Conversation

iHaoo
Copy link
Contributor

@iHaoo iHaoo commented Aug 13, 2020 •
edited
Loading

Fixes #248

iHaoo added 30 commits August 4, 2020 16:25
@iHaoo
Initial resource implementation
8a5ba02
@iHaoo
Updated finder to convert SecretListEntry to DescribeSecretResponse list
5ffef90
@iHaoo
Updated Copyable main model
1f3f442
@iHaoo
Added all relevant parameters with corresponding annotations
01bcb16
@iHaoo
Updated create()
df7120e
@iHaoo
Updated refresh()
f613eb9
@iHaoo
Updated update()
012dd2c
@iHaoo
Updated delete()
ca10895
@iHaoo
Updated findAllAws() to set proper parameters
6bd7f6f
@iHaoo
Removed unnecessary id param
3dc9598
@iHaoo
Updated findAllAws to use paginator and stream
cab6c6a
@iHaoo
Added helper method to convert SecretListEntry to DescribeSecretResponse
f84ebd8
@iHaoo
Updated secretBinary to String
bc0996c
@iHaoo
Removed unnecessary helper method for update()
efaa567
@iHaoo
Updated findAws() to properly return filtered result
d99128d
@iHaoo
Updated tags to create and update properly
9a84818
@iHaoo
Changed all Instant types to String
7ceb318
@iHaoo
Updated delete logic
940f6f1
@iHaoo
Updated tag logic to correctly edit tags
563ea4c
@iHaoo
Added documentation and comments
42a1406
@iHaoo
Added secret.gyro example
a5ea2f8
@iHaoo
Updated licenses
5a02280
@iHaoo
Added Required annotation to Name
83b9fbf
@iHaoo
Added try/catch clause for secrets not found
30e0e9a
@iHaoo
Updated example comments
3119bd6
@iHaoo
Updated docs and annotations
786f485
@iHaoo
Added try/catch clause for not found resource
386e4ac
@iHaoo
Set all output fields of newly created secret
eb784a0
@iHaoo
Consolidate helper method logic
8084ad1
@iHaoo
Added empty list default return if no resource is found
19cef39
deepanjan90
deepanjan90 requested changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@deepanjan90 deepanjan90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well

Some minor coding feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepanjan90 deepanjan90 deepanjan90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Secrets
2 participants
@iHaoo @deepanjan90