Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GYRO-378: ELBV2 Authenticate Cognito Action, primary key will show null if referenced User Pool Client and User Pool Domain not created. #139

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

GYRO-378: ELBV2 Authenticate Cognito Action, primary key will show null if referenced User Pool Client and User Pool Domain not created. #139

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a209657
Update primary key
deepanjan90 Sep 17, 2019
8063826
Merge branch 'master' into bug/fix-primary-key-elbv2-cognito-action
deepanjan90 Sep 18, 2019
89bee61
Merge branch 'master' into bug/fix-primary-key-elbv2-cognito-action
deepanjan90 Sep 18, 2019
175f089
Reformat primary key to avoid extra space when user pool arn not pres…
deepanjan90 Sep 18, 2019
90096f6
Rplace String format with string builder for a cleaner conditional pr…
deepanjan90 Sep 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/gyro/aws/elbv2/AuthenticateCognitoAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,10 @@ public void setUserPoolDomain(UserPoolDomainResource userPoolDomain) {
}

public String primaryKey() {
return String.format("%s/%s/%s", getUserPoolArn(), getUserPoolClient().getId(), getUserPoolDomain().getDomain());
return String.format("%s %s %s",
getUserPoolArn() != null ? getUserPoolArn() : "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to leave an extra space in the output.

Create authenticate-cognito-action  domainexample

getUserPoolClient().getId() != null ? getUserPoolClient().getId() : getUserPoolClient().getName(),
getUserPoolDomain().getDomain());
}

@Override
Expand Down