Add backend support for ownership requests

[gabeweng]

Implement backend for new Ownership Requests feature and update Membership Request feature.

New:

• OwnershipRequest model
• UserMembershipRequestSerializer and OwnershipRequestViewSet to see/create/destroy Ownership Requests for a user
• Routes for users to manage their own requests under api/requests/ownership
• OwnershipRequestSerializer and OwnershipRequestManagementViewSet for management (including accept and deny) of Ownership Requests by club admin and site admin
• Routes for clubs and superusers to manage requests under api/clubs/{club_code}/ownershiprequests
• Email template for sending out ownership requests

Modified:

• MembershipRequest model (person renamed to requester, withdrew renamed to withdrawn, related names for MembershipRequest added for requester and club)
• api/requests/membership used instead of api/requests/ for membership requests

[rm03]

Off to a great start! Left some comments; feel free to reply/reach out with any questions. Please also add some test cases when you get a chance 🙂

[aviupadhyayula]

Thanks for the PR, this looks like a great start! Rohan was (very) thorough, not much to add. One last nit: consider updating the PR's title and description to be a little more descriptive. (Take a look at past PRs for examples.) It's a small detail, but when you're reviewing code years in the future, it's great to understand what the author was thinking.

[codecov]

Codecov Report

Attention: Patch coverage is 90.27778% with 14 lines in your changes missing coverage. Please review.

Project coverage is 72.59%. Comparing base (b280dc0) to head (6315065).

Files with missing lines	Patch %	Lines
backend/clubs/admin.py	66.66%	6 Missing ⚠️
backend/clubs/views.py	91.52%	5 Missing ⚠️
backend/clubs/models.py	91.30%	2 Missing ⚠️
backend/clubs/permissions.py	88.88%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #740      +/-   ##
==========================================
+ Coverage   71.95%   72.59%   +0.63%     
==========================================
  Files          32       32              
  Lines        6953     7056     +103     
==========================================
+ Hits         5003     5122     +119     
+ Misses       1950     1934      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rm03]

Thanks for resolving the comments from earlier! Left a few more, but mostly looks good to me!

[aviupadhyayula]

Great work Gabe! Rohan did a great job with his review, so not much to add outside of minor comments.

[aviupadhyayula]

@rm03 Do you know why we're limiting this to requests that are a week old? I feel like admins should be able to view all requests. We've had situations where someone needs to take over a club a day before the renewal deadline / Wharton applications / club fair.

[rm03]

The idea was that we give club owners a week to resolve the request before it goes to OSA; if we show all requests to OSA at once, they might resolve the request before the club owners have a chance to address it. This could be problematic in the scenario that you described, so maybe we should show all requests but highlight the ones that are over a week old on the frontend.

[aviupadhyayula]

Sounds good, definitely agree with the frontend part. @gabeweng do you mind tweaking this to return all requests, and then sort by created_at so that oldest requests show up first?