Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for empty responses before application submission #724

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aviupadhyayula
Copy link
Member

Currently, users can hit the submit button with questions that don't have an answer. This PR adds a check over all questions in an application before calling the submit route.

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.40%. Comparing base (c62603f) to head (18a3965).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #724   +/-   ##
=======================================
  Coverage   71.40%   71.40%           
=======================================
  Files          31       31           
  Lines        6850     6850           
=======================================
  Hits         4891     4891           
  Misses       1959     1959           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rm03 rm03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if a question is optional and the user leaves it blank?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants