-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated linter fix - (Built on django-migrate and NOT main) #312
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! Can you please take a look at penn-mobile's configs and see if playing with those helps anything (ex. codecov)? Let me know the results!
Main issue with codecov is just the token I believe. Error message on running codecov: 'Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.' If the upload token is shared I'll keep looking into it. If it's ohq specific, I'll need to ask Bach or Dan to add it into our secrets |
Makes sense, lmk if you stumble into anything else |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## django-migrate #312 +/- ##
=================================================
Coverage ? 98.93%
=================================================
Files ? 25
Lines ? 1316
Branches ? 0
=================================================
Hits ? 1302
Misses ? 14
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Codecov token added. All tests pass. |
Restore backend checks for ohq deployment.