Skip to content
This repository has been archived by the owner on Nov 22, 2017. It is now read-only.

fix minimised view position on orientation change #71

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

frakc
Copy link

@frakc frakc commented Sep 22, 2015

Before, there were few bugs, which appeared, when using manual orientation change handling:

  1. if view was minimized - it disappeared after rotation.
  2. if view was closed to left or right - closed view appeared as minimized near left or right edge of screen

This PR fixes that in following way:

if view is not closed or at top - view will be repositioned as minimized *method closeToRight(), closeToLeft push view mach further (adding to width max screen dimension) , so in any position it will be out of screen

@pedrovgs
Copy link
Owner

@frakc can you review this PR? The build is failing :(

@frakc
Copy link
Author

frakc commented Sep 29, 2015

it is something with check style, How to use checkstyle plugin?
Buy the way, does resize transformer work at all (when i doenloaded demo and run on my tablet (android 5.02, it freesed)? Cause I have another commit which gratly improve positioning with scale transfromer and probably will brake resize transformer.

@frakc
Copy link
Author

frakc commented Oct 6, 2015

@pedrovgs Horray, it finaly passed:) You probably has to validate if there is negative impact on recize transformer, as i could not, on version 1.8 it always freees on my devices

@frakc
Copy link
Author

frakc commented Oct 6, 2015

@pedrovgs also check you checkstyle for <module name="RedundantThrows"/> it seems, that check style does not support it any more. loading checkstyle file with it causes loading crash

@pedrovgs
Copy link
Owner

@frakc your implementation to keep the view state after the device rotation is not valid. Using android:configChanges="keyboardHidden|orientation|screenSize" in the sample activity you are configuring your activity to not reset the activity lifecycle. This implementation is not valid because if the library user wants to show different layout in portrait or landscape this implementation is not going to work.

Related to the checkstyle, this one is the one used by Square. I suggest you to review your code instead of remove the rule failing.

I've also seen some files modified just to add some white spaces should not be there or splitting lines. Review this files and revert your changes please, these changes are just adding noise to the PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants