Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a margo-based implementation of the mercury-progressor. This implementation can be enabled by providing
-DENABLE_MARGO=ON
to cmake.From an API perspective, existing codes can continue to use the exact same API. The use of Margo will simply change how the progress loop is managed internally. Enabling margo also provides two extra functions:
mercury_progressor_init_from_margo(margo_instance_id mid)
to initialize a progressor using an existing margo instances;mercury_progressor_mid(progressor_handle_t*)
to get a margo instance from a progressor handle.This PR also improves the existing test to add an RPC, and provides another test when margo is enabled, in which one RPC is done using Mercury and another is done concurrently using Margo, showing interoperability.
Contrary to the original implementation of the mercury progressor, the Margo-based implementation will keep the progress thread running all the time (the original implementation stopped the thread when it wasn't needed and respawned it when needed). This is something that could be fixed, if needed (we don't have a way right now to pause the progress loop in Margo, but we have an old PR with the feature, that was never merged and that we could revisit).