-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test creation page #17
Open
harshnarang8
wants to merge
9
commits into
pclubiitk:master
Choose a base branch
from
harshnarang8:temp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Uses ftp to verify user with iitk servers. Only the backend part. How to test: The complete login can be tested manually using `httpie`. Run `node app` and then test using the following commands: ``` http get "localhost:8000" http get "localhost:8000/profile" ``` ^ Will redirect to `/login` ``` http post "localhost:8000/login" email="[email protected]" password="shaktimaan" ``` ^ If password is correct will redirect to `/profile` in the output ``` http post "localhost:8000/login" email="[email protected]" password="batman" ``` ^ If password is wrong will redirect to `/login` Pool: ``` __ __ _ _ | \/ | __ _ _ __ __ _| |_| |__ __ _ ___ | |\/| |/ _` | '__/ _` | __| '_ \ / _` / __| | | | | (_| | | | (_| | |_| | | | (_| \__ \ |_| |_|\__,_|_| \__,_|\__|_| |_|\__,_|___/ ```
Summary: Finished yashsriv's backend with an ejs based front-end (login page and a test profile page for a successful login). How to Test: In the Server directory: ``` node app ``` Then direct your browser to localhost:8000 and test it out. If password is correct, you're redirected to a test-profile page listing your access rights and username. If your input is incorrect, you will be directed again to the /login page, with a toast displaying what went wrong on the top right. Reason for Using EJS: I wanted a decent way to manage views as the content would change with the user. This seemed to be a quick and simple way to do that. Also, it looks quite neat. Pool: ``` __ __ _ _ | \/ | __ _ _ __ __ _| |_| |__ __ _ ___ | |\/| |/ _` | '__/ _` | __| '_ \ / _` / __| | | | | (_| | | | (_| | |_| | | | (_| \__ \ |_| |_|\__,_|_| \__,_|\__|_| |_|\__,_|___/ ```
Revert "Add frontend for login using ejs" since it is redundant This reverts commit b043984. It is redundant as @harshnarang8 already has contributed something. Add form to login.html add footer login.html add user.html basic update login form with error message update login.html page layout remove user.html empty file add id for inputCheckBox
merge login page commits update login.html page layout add id for inputCheckBox add id for inputCheckBox Wrapper added Halfway thro Revert "Halfway thro" This reverts commit 4dcf506. Worked on GUI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An updated pull request instead of the previous one.
The page can be used to create a test, and has improved UI, better js code (DOM manipulation :P), and the Test is sent as a JSON object.
Outline pages for users have been added.