fix issue #3 : Create StreamDescriptionOverlay component #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lay-Component.tsx
BipplavTiwari
changed the title
BipplavTiwari
changed the title
mridul911
approved these changes
Jun 14, 2021
Comment on lines
42
to
43
| const [myIcon, setmyIcon] = following? useState("bell-slash") : useState("bell"); | ||
| const [buttonColor, setbuttonColor] = following? useState("#1762e3") : useState("#ff0000"); |
There was a problem hiding this comment.
Instead of defining these states directly use this condition inside Icon.Button like this.
name={following ? "bell-slash" : "bell"}
There was a problem hiding this comment.
Made suggested changes.
| const [following,changefollowing]=useState(props.isFollowed); | ||
| const [myIcon, setmyIcon] = following? useState("bell-slash") : useState("bell"); | ||
| const [buttonColor, setbuttonColor] = following? useState("#1762e3") : useState("#ff0000"); | ||
| function changeit(){ |
There was a problem hiding this comment.
use arrow functions instead of normal one.
There was a problem hiding this comment.
Made suggested changes.
mridul911
approved these changes
Jun 14, 2021
Comment on lines
66
to
68
| const toggleOverlay = () => { | ||
| setVisible(!visible); | ||
| }; |
There was a problem hiding this comment.
don't write separate function for this directly use this like onBackDropPress{()=>setVisible(false)}
There was a problem hiding this comment.
Made suggested changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created StreamDescriptionOverlay component.
Resolves #3