fix: prevent undefined device ID when namespace #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danzhaaspaypal
approved these changes
Oct 10, 2023
jadutter
approved these changes
Oct 16, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
### [1.49.2](v1.49.1...v1.49.2) (2023-10-18) ### Bug Fixes * prevent undefined device ID when namespace ([#994](#994)) ([fe91522](fe91522)) * safari focus ([#1005](#1005)) ([827a56d](827a56d)) * safari focus ([#997](#997)) ([5b4a823](5b4a823)) ### Code Refactoring * disable tab trap on api or lander ([#999](#999)) ([ab92760](ab92760))
|
🎉 This PR is included in version 1.49.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes include 2 fixes
"undefined"being passed up to the experiments endpoint because the SDK instance running inside the IFrame does not get passed the custom namespace and will always use the default namespace. To fix this issue we pass the default namespace into the IFrame to be used instead.belterstorage helper to ensure that thebelterstorage instance used by the SDK does not get out of sync with our manual mutations of local storage directly.Screenshots
N/A
Testing instructions
N/A