Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update when error icon shows in Pay Monthly modal #988

Merged
merged 2 commits into from
Oct 10, 2023
Merged

refactor: update when error icon shows in Pay Monthly modal #988

merged 2 commits into from
Oct 10, 2023

Conversation

yeul
Copy link
Contributor

@yeul yeul commented Sep 20, 2023

Description

  • Changes when error icon shows in Pay Monthly modal. Will now only show when a user interacts with the calculator input field and enters an amount < min amount or > max amount. Will no longer show when a merchant does not enter an amount or enters a non-qualifying amount.

Screenshots

N/A

Testing instructions

N/A

@yeul yeul added the snapshots Trigger new snapshots to be generated label Sep 20, 2023
@yeul yeul removed the snapshots Trigger new snapshots to be generated label Sep 20, 2023
@jadutter jadutter merged commit 08c126f into paypal:develop Oct 10, 2023
github-actions bot pushed a commit that referenced this pull request Oct 11, 2023
@semantic-release-bot
chore(release): 1.49.1 [skip ci]
50a7d37 
### [1.49.1](v1.49.0...v1.49.1) (2023-10-11)

### Code Refactoring

* enable passing multiple merchant ids ([#992](#992)) ([4ac100f](4ac100f))
* update modal css ([#996](#996)) ([8dc900d](8dc900d))
* update when error icon shows in Pay Monthly modal ([#988](#988)) ([08c126f](08c126f))
@github-actions
Copy link

🎉 This PR is included in version 1.49.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grablack grablack grablack approved these changes

Assignees
No one assigned
Labels
approved released testing complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yeul @grablack @jadutter