fix: components render inside external zoid iframes #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gillycheesesteak
approved these changes
Sep 15, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Sep 20, 2023
### [1.48.1](v1.48.0...v1.48.1) (2023-09-20) ### Bug Fixes * components render inside external zoid iframes ([#986](#986)) ([72a1831](72a1831))
|
🎉 This PR is included in version 1.48.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently have a util function
isZoidComponent()that we use to prevent certain logic from running inside or IFrames, such as scanning the page for elements with thedata-pp-messageattribute to auto-render messages. This check looks for__zoid__windows to prevent this. This has a side-effect of preventing other merchants from usingzoidto render our components inside an IFrame. The following change has been made to help address this:isZoidComponent()util to explicitly look for the tags of ourzoidcomponentsScreenshots
N/A
Testing instructions
Attached is an example that can be placed into the
demo/directory to reproduce the scenario.paypal-zoid.zip