feat: updated input on calculator for better accessibility #985
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perco12
changed the title
|
Looks good, just one spot we might want to fix, this screen shot shows the screen reader text with and without your changes. For some reason i'm seeing "invalid data" with your changes. I think we won't want that experience. 
|
…highlighted with a value other then a number
erikacolette29
approved these changes
Sep 21, 2023
|
🎉 This PR is included in version 1.49.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The screen readers read the correct input types and doesn't read the calculator's input as type "telephone" but still ensures the numerical keyboard comes up on mobile
Screenshots