Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update github script #1145

Merged
merged 2 commits into from
Oct 15, 2024
Merged

chore: update github script #1145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
944c7fb
update github script
surekhaw Oct 14, 2024
1459bd7
remove imgur from workflow
surekhaw Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/snapshotCommit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
repository: ${{ github.event.workflow_run.head_repository.full_name }}

- name: Download Artifacts
uses: actions/github-script@v3.1.0
uses: actions/github-script@v7
with:
script: |
const fs = require('fs');
Expand Down Expand Up @@ -66,7 +66,7 @@ jobs:

- name: Reset Label
if: github.event.workflow_run.event == 'pull_request'
uses: actions/github-script@v3.1.0
uses: actions/github-script@v7
with:
# The workflow_run that comes along with the event drops the PR number for some reason
# so we have to pass the PR number from the original workflow as an artifact
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/snapshotCompare.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ jobs:
run: |
npm run test:func -- --testPathPattern "${{ matrix.testPathPattern }}"

- name: Collect Diffs and Upload to Imgur
run: |
./scripts/snapshot-tests/collect-diffs.sh
# - name: Collect Diffs and Upload to Imgur
# run: |
# ./scripts/snapshot-tests/collect-diffs.sh

compareSnapshotsV2:
name: Compare V2
Expand Down Expand Up @@ -101,6 +101,6 @@ jobs:
run: |
CONFIG_PATH=${{ matrix.testConfig }} npm run test:func:snapshots

- name: Collect Diffs and Upload to Imgur
run: |
./scripts/snapshot-tests/collect-diffs-v2.sh
# - name: Collect Diffs and Upload to Imgur
# run: |
# ./scripts/snapshot-tests/collect-diffs-v2.sh
Loading