Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update ppc ni min amount #1144

Merged
merged 4 commits into from
Oct 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion content/messages/US/ppc_ni_nq.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"headline": [
["Buy now. Pay over time.", ["default", "xsmall", "small"]],
[
["No Interest if paid in full in 6 months", ["on purchases of $99+.", "weak"]],
["No Interest if paid in full in 6 months", ["on purchases of {formattedMinAmount}+.", "weak"]],
["medium", "large", "xlarge"]
]
],
Expand Down
2 changes: 1 addition & 1 deletion content/messages/US/ppc_ni_nq_xb.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"headline": [
["Buy now. Pay over time.", ["default", "xsmall", "small"]],
[
["No Interest if paid in full in 6 months", ["on purchases of $99+", "weak"]],
["No Interest if paid in full in 6 months", ["on purchases of {formattedMinAmount}+", "weak"]],
["medium", "large", "xlarge"]
]
],
Expand Down
2 changes: 1 addition & 1 deletion content/messages/US/ppc_ni_q.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"headline": [
["Buy now. Pay over time.", ["default", "xsmall", "small"]],
[
["No Interest if paid in full in 6 months", ["on purchases of $99+.", "weak"]],
["No Interest if paid in full in 6 months", ["on purchases of {formattedMinAmount}+.", "weak"]],
["medium", "large", "xlarge"]
]
],
Expand Down
2 changes: 1 addition & 1 deletion content/messages/US/ppc_ni_q_xb.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"headline": [
["Buy now. Pay over time.", ["default", "xsmall", "small"]],
[
["No Interest if paid in full in 6 months", ["on purchases of $99+", "weak"]],
["No Interest if paid in full in 6 months", ["on purchases of {formattedMinAmount}+", "weak"]],
["medium", "large", "xlarge"]
]
],
Expand Down
6 changes: 3 additions & 3 deletions content/modals/US/legacy_ppc_ni.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@
"title": "Buy now and pay over time with PayPal Credit",
"subtitle": "Subject to credit approval.",
"terms": {
"title": "No Interest if paid in full in 6 months on purchases of $99 or more",
"title": "No Interest if paid in full in 6 months on purchases of $149 or more",
"items": [
"Interest will be charged to your account from the purchase date if the balance is not paid in full within 6 months.",
"A minimum monthly payment is required and may or may not pay off the promotional purchase by the end of the 6 month period.",
"No interest will be charged on the purchase if you pay it off in full within 6 months. If you do not, interest will be charged on the purchase from the purchase date at the Purchase APR applicable to your account.",
"For New Accounts: Variable Purchase APR is {aprEntry.apr}%. The APR is accurate as of {aprEntry.formattedDate} and will vary with the market based on the Prime Rate (as defined in your credit card agreement). Minimum interest charge is $2.00.",
"Individual items that are less than $99 qualify for special financing when combined for a total of $99 or more in a single transaction.",
"Multiple separate transactions of less than $99 per transaction cannot be combined to meet the minimum purchase amount."
"Individual items that are less than $149 qualify for special financing when combined for a total of $149 or more in a single transaction.",
"Multiple separate transactions of less than $149 per transaction cannot be combined to meet the minimum purchase amount."
]
},
"instructions": {
Expand Down
6 changes: 3 additions & 3 deletions content/modals/US/v2_ppc_ni.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,15 @@
"instructions": [
"Apply now and get a decision in seconds.",
"Check out with PayPal and choose <strong>PayPal Credit</strong>.",
"No Interest if paid in full in 6 months on purchases of $99+"
"No Interest if paid in full in 6 months on purchases of {formattedMinAmount}+"
],
"terms": [
"Interest will be charged to your account from the purchase date if the balance is not paid in full within 6 months.",
"A minimum monthly payment is required and may or may not pay off the promotional purchase by the end of the 6 month period.",
"No interest will be charged on the purchase if you pay it off in full within 6 months. If you do not, interest will be charged on the purchase from the purchase date at the Purchase APR applicable to your account.",
"For New Accounts: Variable Purchase APR is {aprEntry.apr}%. The APR is accurate as of {aprEntry.formattedDate} and will vary with the market based on the Prime Rate (as defined in your credit card agreement). Minimum interest charge is $2.00.",
"Individual items that are less than $99 qualify for special financing when combined for a total of $99 or more in a single transaction.",
"Multiple separate transactions of less than $99 per transaction cannot be combined to meet the minimum purchase amount."
"Individual items that are less than {formattedMinAmount} qualify for special financing when combined for a total of {formattedMinAmount} or more in a single transaction.",
"Multiple separate transactions of less than {formattedMinAmount} per transaction cannot be combined to meet the minimum purchase amount."
],
"buttonText": "Apply Now",
"disclaimer": "Subject to credit approval",
Expand Down
2 changes: 1 addition & 1 deletion content/modals/US/v2_product_list.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"credit": [
{
"header": "PayPal Credit",
"body": "No Interest if paid in full in 6 months for purchases of $99+.",
"body": "No Interest if paid in full in 6 months for purchases of $149+.",
"viewName": "PAYPAL_CREDIT_NO_INTEREST"
}
]
Expand Down
3 changes: 2 additions & 1 deletion src/components/modal/v2/parts/views/ProductList/Content.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import { h, Fragment } from 'preact';
import { useServerData } from '../../../lib';
import Tile from '../../Tile';
import { currencyFormat } from '../../../lib/hooks/currency';
import styles from './styles.scss';

export const ProductList = ({ content: { instructions, disclosure, productTiles }, useV5Design, setViewName }) => {
Expand Down Expand Up @@ -43,7 +44,7 @@ export const ProductList = ({ content: { instructions, disclosure, productTiles
availableTiles.credit?.map(({ header, body, viewName }) => (
<Tile
header={header}
body={body}
body={currencyFormat(body)}
viewName={viewName}
setViewName={setViewName}
useV5Design={useV5Design}
Expand Down
5 changes: 3 additions & 2 deletions src/server/message/parts/MutatedText.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const MutatedText = ({ tagData, options }) => {
// truncate zeros for non-qualifying messages
const matchNQ = formattedStr.match(
// eslint-disable-next-line security/detect-unsafe-regex
/((\$|£)?(\d{1,5}(\.|,)){1,3}00(€|(.|\s*)EUR)?(-|(\s(\D{1,3})\s))(\$|£)?(\d{1,5}(\.|,|\s)){1,3}00(€|(.|\s*)EUR)?)/g
/((\$|£)?(\d{1,5}(\.|,)){1,3}00(€|(.|\s*)EUR)?((-|(\s(\D{1,3})\s))(\$|£)?(\d{1,5}(\.|,|\s)){1,3}00(€|(.|\s*)EUR)?|\+))/g
);
if (matchNQ !== null) {
matchNQ.forEach(foundString => {
Expand All @@ -49,7 +49,8 @@ const MutatedText = ({ tagData, options }) => {
.replace(/(\.|,)00$/g, '')
.replace(/(\.|,)00€/g, '€')
.replace(/(\.|,)00(.|\s*)EUR/g, '€')
.replace(/(\s*EUR)/g, '€');
.replace(/(\s*EUR)/g, '€')
.replace(/(\.|,)00(\+)/g, '+');
formattedStr = formattedStr.replace(foundString, filteredString);
});
}
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading