Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds screenreader visual focus on donut text #1012

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

danzhaaspaypal
Copy link
Contributor

Description

Adds screenreader visual focus on donut text

Screenshots

Screenshot 2023-10-30 at 10 13 45 AM

Testing instructions

I suggest using Browserstack to test the following popular combinations of operating systems, screen readers, and browsers:

  • Android OS + Chrome + Screen Reader
  • iOS + Safari + VoiceOver
  • iOS + Chrome + VoiceOver
  • MacOS + Voiceover + safari
  • Windows + NVDA + Firefox
  1. Navigate to a Pay In 4 Modal
  2. Use screen reader to read the payment schedule content
  3. Verify that the screen reader says and highlights the content of the payment schedule text correctly.

@danzhaaspaypal danzhaaspaypal requested a review from yeul October 30, 2023 14:21
@danzhaaspaypal danzhaaspaypal merged commit c503af2 into develop Oct 30, 2023
49 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 31, 2023
## [1.50.0](v1.49.2...v1.50.0) (2023-10-31)

### Features

* update modal logo a11y ([#1009](#1009)) ([03bfc6c](03bfc6c))

### Bug Fixes

* adds screenreader visual focus on donut text ([#1012](#1012)) ([c503af2](c503af2))
* au flex 8x1 spacing ([#1008](#1008)) ([d762500](d762500))
* screen reader for the list of ineligible states reads some state abbreviations as words instead of letters ([#943](#943)) ([c4c7c41](c4c7c41))

### Continuous Integration

* jenkins messaging bundles ([#993](#993)) ([36e9b3b](36e9b3b))

### Code Refactoring

* remove deprecated v1 modal code ([#1002](#1002)) ([3da52ed](3da52ed))
* update native modal event keys and values ([#1010](#1010)) ([71ab32e](71ab32e))
Copy link

🎉 This PR is included in version 1.50.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants