-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: safari focus #1005
Merged
merlinpaypal
merged 15 commits into
paypal:develop
from
jadutter:hotfix/safari-modal-focus
Oct 17, 2023
Merged
fix: safari focus #1005
merlinpaypal
merged 15 commits into
paypal:develop
from
jadutter:hotfix/safari-modal-focus
Oct 17, 2023
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added debug messages and listeners to view events and their order - adjusted how focus is handled when the modal opens and closes - added some aria attributes to increase accessibility
github-actions bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
### [1.49.2](v1.49.1...v1.49.2) (2023-10-18) ### Bug Fixes * prevent undefined device ID when namespace ([#994](#994)) ([fe91522](fe91522)) * safari focus ([#1005](#1005)) ([827a56d](827a56d)) * safari focus ([#997](#997)) ([5b4a823](5b4a823)) ### Code Refactoring * disable tab trap on api or lander ([#999](#999)) ([ab92760](ab92760))
🎉 This PR is included in version 1.49.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#997
useAutoFocus
Improve debuggingadded debug levels to control logging verbosityadded debug messages and listeners to view events and their orderScreenshots
Testing instructions