Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: safari focus #1005

Merged
merged 15 commits into from
Oct 17, 2023
Merged

Conversation

jadutter
Copy link
Contributor

Description

#997

  • Improve accessibility
    • adjusted how focus is handled when the modal opens and closes
    • added some aria attributes to increase accessibility
    • Updated the prerender modal close button to receive focus when opened
  • Updated the prerender modal
    • close button to look identical to the modal close button
    • cleaned up some lint issues
  • Removed unused code useAutoFocus
  • Improve debugging
    • added debug levels to control logging verbosity
    • added debug messages and listeners to view events and their order
    • split into a separate PR

Screenshots

Testing instructions

@merlinpaypal merlinpaypal merged commit 827a56d into paypal:develop Oct 17, 2023
41 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 18, 2023
### [1.49.2](v1.49.1...v1.49.2) (2023-10-18)

### Bug Fixes

* prevent undefined device ID when namespace ([#994](#994)) ([fe91522](fe91522))
* safari focus  ([#1005](#1005)) ([827a56d](827a56d))
* safari focus ([#997](#997)) ([5b4a823](5b4a823))

### Code Refactoring

* disable tab trap on api or lander ([#999](#999)) ([ab92760](ab92760))
@github-actions
Copy link

🎉 This PR is included in version 1.49.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants