Migrate PayPalWebClient Analytics Logic Into PayPalWebAnalytics Class #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshropshire
commented
Nov 26, 2024
| class CardAnalytics( | ||
| private val analyticsService: AnalyticsService | ||
| ) { | ||
| internal class CardAnalytics(private val analyticsService: AnalyticsService) { |
There was a problem hiding this comment.
Marking analytics related classes internal. I forgot to add this in the previous PR so adding it here now.
| @@ -5,7 +5,6 @@ import android.content.Intent | |||
| import android.util.Log | |||
| import androidx.activity.ComponentActivity | |||
| import com.paypal.android.corepayments.CoreConfig | |||
| import com.paypal.android.corepayments.PayPalSDKError | |||
There was a problem hiding this comment.
How come you don't need this now?
There was a problem hiding this comment.
Looks like this import was only used in a function declaration e.g.
private fun notifyWebCheckoutFailure(error: PayPalSDKError, orderId: String?) {}We removed those methods and the import got flagged by detekt as no longer needed.
There was a problem hiding this comment.
Is it not needed because the launcher imports PayPalWebCheckoutError? I think I got it.
KunJeongPark
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
PayPalWebAnalyticsclass to encapsulate analytics notification logicChecklist
Added a changelog entryAuthors