Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Remove 3DS URL Parsing #296

Merged
merged 4 commits into from
Nov 21, 2024
Merged

[1.x] Remove 3DS URL Parsing #296

merged 4 commits into from
Nov 21, 2024

Conversation

sshropshire
Copy link
Collaborator

Summary of changes

  • Remove unnecessary URL parsing from all Card 3DS routes to obtain feature parity with iOS
  • We are back-porting this change to v1
  • We made the same change in v2: Remove 3DS URL Parsing #294

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire sshropshire marked this pull request as ready for review November 21, 2024 19:34
@sshropshire sshropshire requested a review from a team as a code owner November 21, 2024 19:34
uses: actions/checkout@v4
with:
ref: main
- name: Assemble Release AAR on Main Branch
ref: 1.x
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This GitHub Action compares SDK size with previous versions. I had to update these to create a separate set of artifacts for 1.x releases because :PayPalNativePayments is no longer being built on main (this causes the action to fail).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify this is only for 1.x releases and should not affect main in any way.

@sshropshire sshropshire merged commit 9116b84 into 1.x Nov 21, 2024
6 checks passed
@sshropshire sshropshire deleted the 1.x__remove_3ds_url_parsing branch November 21, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants