Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DS-252 Updating Blinky to latest version and other HTML improvements #82

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

DS-252 Updating Blinky to latest version and other HTML improvements #82

wants to merge 5 commits into from

Conversation

diturner
Copy link
Contributor

  • Blinky is now at v0.72.1
  • Fixed the form next / previous actions, this was being caused by the browser being unable to keep track of the elements it needed to scroll to given we're hiding / showing the active field groups
  • Removed the theme selector, this can be added back in once work has been done to the ER Diagram Designer CSS
  • Added a small fix make sure the ER Diagram Designer opens above the header (this was caused by a difference in newer Blinky version of element layering)
  • Removing the unneeded <div>s mentioned in FISH-10039
  • Moved the ER Diagram Designer CSS into the header as CSS isn't allowed in the body
  • Added some code to stop the page scrolling in the background if the ER Diagram Designer popup is open
  • Fixed HTML validation errors
    • Removed the self-closing /s
    • Moved the copyright notice HTML comment to after the <meta charset="UTF-8"> because it's pushing this line down outside the first 1024 bytes and causing an error
  • Swapped the paragraph of text to a p rather than an h2 as what's wanted here is the text size, not to mark it as a title

Di Turner added 5 commits November 13, 2024 11:47
FISH-10039 Removed incorrectly nested div tags.
e59d11b 
Divs cannot be nested inside P tags, this is the original cause of the
footer spacig issue.
DS-252 updated to Blinky version 0.72.1.
14836f1
DS-252 Added some styling for smaller screens to handle the header an…
ef7160c 
…d footer content.

This can't be done in Blinky as it's dependant on actual amounts of
content. If the window is less than 700 pixels wide the content in the
header and footer shift to stacked and centred.
DS-252 fixes and improvements to page.
cb5ce4d 
Moved the diegram designer CSS into the head as it breaks validation to
put it in the footer.
Added a fix to ensure the diagram popup opens above the page header.
Removed the self closing /'s on BRs and INPUTSs.
Moved the copyright notice HTML comment because it's so long it cuases a
validation error that the meta charset is outside the first 1024 bytes.
Swapped the H2 content to a P with H2 styling as it isn't actually a
title, we just want larger text.
Removed the theme selector and forced light theme, this is a temporary
quick fix for the diagram designer not working with Blinky styles.
DS-252 Remved the unneeded space between two checkboxes.
33f4740
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jGauravGupta jGauravGupta jGauravGupta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diturner @jGauravGupta