Fix issue with wrap(string_view&&) being ambiguous

pawelwod · Nov 1, 2023 · 38fa1f0 · 38fa1f0
1 parent 83e307a
commit 38fa1f0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/include/scn/detail/range.h b/include/scn/detail/range.h
@@ -522,8 +522,8 @@ namespace scn {
 
 #if SCN_HAS_STRING_VIEW
                 template <typename CharT>
-                static auto impl(const std::basic_string_view<CharT>& str,
-                                 priority_tag<1>) noexcept
+                static auto impl(std::basic_string_view<CharT> str,
+                                 priority_tag<2>) noexcept
                     -> range_wrapper<basic_string_view<CharT>>
                 {
                     return {basic_string_view<CharT>{str.data(), str.size()}};

diff --git a/test/std_string_view.cpp b/test/std_string_view.cpp
@@ -41,4 +41,11 @@ TEST_CASE("getline std::string_view")
     CHECK_EQ(std::memcmp(sv.data(), "foo", 3), 0);
 }
 
+TEST_CASE("input std::string_view")
+{
+    std::string_view out;
+    auto ret = scn::scan(std::string_view{"foo"}, "{}", out);
+    CHECK(ret);
+    CHECK_EQ(out, "foo");
+}
 #endif