Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: implement a way to temporarily ignore redirect #265

Merged
merged 5 commits into from
Sep 8, 2023
Merged

FEATURE: implement a way to temporarily ignore redirect #265

merged 5 commits into from
Sep 8, 2023

Conversation

merefield
Copy link
Member

  • permits admin to provide links to forum that can open in new tab, without redirecting back to wizard.
  • any attempt to navigate forum from there will cause forum to redirect to wizard

@merefield merefield marked this pull request as draft September 6, 2023 12:31
@merefield merefield marked this pull request as ready for review September 6, 2023 15:30
@merefield merefield changed the title FEATURE: implement way to temporarily ignore redirect FEATURE: implement a way to temporarily ignore redirect Sep 6, 2023
@angusmcleod
Copy link
Member

@merefield can a you a qunit test for this please.

@merefield
Copy link
Member Author

@angusmcleod I'd assumed this was untestable because during qunit the address in the browser is inappropriate. Turns out Discourse team has thought of that ... so updated my code to be testable and added test 👍

@angusmcleod angusmcleod merged commit 52efc15 into main Sep 8, 2023
5 checks passed
@angusmcleod angusmcleod deleted the temp_ignore_redirect branch September 8, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angusmcleod angusmcleod angusmcleod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merefield @angusmcleod