add PageToken to getPlayListsItemsById #21
Conversation
Make also maxResults as optionnal param for retro compatibility
|
In Review. Please wait. |
|
I could use the pageToken functionality in this PR as well. |
|
Hello @paulomcnally, can i do something to help on this pr review ? |
lib/youtube.js
Outdated
| @@ -175,17 +189,33 @@ var YouTube = function() { | |||
| /** | |||
| * Playlists data from Playlist Id | |||
| * @param {string} id | |||
| * @param {int} [maxResults] | |||
|
Any progress on the review ? I'm really glad to benefit from this open-source project but this PR has been opened 685 days ago and i'm wondering if this project is still maintained. Thank you for your feedbacks |
example/get-playlist-items.js
Outdated
| @@ -4,7 +4,7 @@ var config = require('./config'); | |||
| var youTube = new YouTube(); | |||
|
|
|||
| youTube.setKey(config.key); | |||
| youTube.getPlayListsItemsById('PLpOqH6AE0tNhInmRTSNf9f6OQsdaSJS8F', function(error, result) { | |||
| youTube.getPlayListsItemsById('PLpOqH6AE0tNhInmRTSNf9f6OQsdaSJS8F', 8, function(error, result) { | |||
There was a problem hiding this comment.
Hmm just wondering - why is the maxResults set to such a seemingly arbitrary number as 8?
|
@piercus: Seems master has been updated since this PR was made. Actually, the "add maxResults" has already been done in the current version of this repo. So you should rename this PR to "add PageToken to getPlayListsItemsById" because that's the only new argument. //Just another guy who uses this library |
piercus
changed the title
|
@niklasHagner thank you for your comments.
Tell me what you think Travis is failing but i think this is due to misconfiguration of the travis build which should have |
|
Looks good 👍 |
No description provided.