libjuice: cmake find does not use correct names on imported target #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, I discovered this while trying to make a conan package for libdatachannel. Others from conan are helping with the packaging, so it's almost ready: conan-io/conan-center-index#26013 |
paullouisageneau
approved these changes
Nov 28, 2024
paullouisageneau
added a commit
that referenced
this pull request
Nov 28, 2024
libjuice: cmake find does not use correct names on imported target
|
Released in |
|
By the way, you can find the conan package here: https://conan.io/center/recipes/libdatachannel?version=0.22.2 Maybe it could be mentioned in the readme? |
|
Yes, I added a link in the readme. Thank you for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plural names are used but it should be e.g JUICE_INCLUDE_DIR instead of JUICE_INCLUDE_DIRS
This problem only occurs when you use an external system libjuice.