Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where packets retransmitted for NACK are encrypted with SRTP twice #1198

Closed
wants to merge 1 commit into from
Closed

Fix a bug where packets retransmitted for NACK are encrypted with SRTP twice #1198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/rtcpnackresponder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,14 @@ optional<binary_ptr> RtcpNackResponder::Storage::get(uint16_t sequenceNumber) {
: nullopt;
}

void RtcpNackResponder::Storage::store(binary_ptr packet) {
if (!packet || packet->size() < sizeof(RtpHeader))
void RtcpNackResponder::Storage::store(binary_ptr message) {
if (!message || message->size() < sizeof(RtpHeader))
return;

// We need to create a deep copy of the message binary here because the content
// of the binary will be modified by the srtp_protect() function when the message is sent.
auto packet = std::make_shared<binary>(message->begin(), message->end());

auto rtp = reinterpret_cast<RtpHeader *>(packet->data());
auto sequenceNumber = rtp->seqNumber();

Expand Down
Loading