Migrate session-level attributes to media-level #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-pwd` to the media-level in `Description::generateSdp(...)`. The goal here is to have better general compatibility as RFC 8829 recommends using the media-level attributes even if the information is identical.
|
Thanks for the feedback! I removed the changes to |
paullouisageneau
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves session-level attributes for
a=setup,a=ice-ufrag,a=ice-pwd,a=ice-optionsanda=fingerprintto the media-level inDescription::generateSdp(...). The goal here is to have better general compatibility as RFC 8829 recommends using the media-level attributes even if the information is identical.Another goal of this change was to not introduce breaking API changes, and the easiest way to accomplish this was to print out the information right after the entry SDP on the Description level. The "downside" of this approach is that it will appear at the end of the media entry, but I don't believe this will impact parsing as long as it is grouped with the media.
Let me know what you think, happy to make any changes!