Fix misaligned dereference in H264 and H265 packetizers #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use memcpy instead of direct dereference to avoid misaligned access.
There was a problem hiding this comment.
Thank you for the fix!
There is the exact same issue in H265RtpPacketizer, would you mind applying the same fix there too please?
libdatachannel/src/h265rtppacketizer.cpp
Line 36 in 5064b0b
Fixed |
paullouisageneau
approved these changes
Apr 15, 2024
paullouisageneau
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use memcpy instead of direct dereference to avoid
misaligned access.