Add FrameInfo #1121
Closed
Add FrameInfo #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sean-Der
force-pushed
the
frame-info
branch
5 times, most recently
from
fab084d to
1c75ffd
Compare
|
@paullouisageneau this is ready for review, thank you! |
There was a problem hiding this comment.
As I understand, you use the same MediaSample for storing metadata and sometimes data, so it also inherits from binary. Why not simply adding a pure metadata strut (I actually liked the name FrameInfo) that you'd pass to the user alongside the data, for instance with onFrame(std::function<void(binary data, FrameInfo frame)>?
|
@paullouisageneau 👍 will fix that now! |
Depacketizers will include metadata about assembled media.
|
@paullouisageneau done! Can I get another review please? |
|
Moved to Opus PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depacketizers will include metadata about assembled frame.