Fix crash in IceTransport::TimeoutCallback with libnice #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullouisageneau
force-pushed
the
fix-crash-timeoutcallback-nice
branch
2 times, most recently
from
c3535fb to
a390eac
Compare
paullouisageneau
force-pushed
the
fix-crash-timeoutcallback-nice
branch
from
a390eac to
294f64c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a possible race condition when destroying
IceTransportwith libnice: the destructor disarms the timer, the nice agent changes states and rearms the timer, then the destructor destroys the nice agent. It would result inIceTransport::TimeoutCallbackbeing called later for a destroyed object.It should fix #1102