Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the target location of the FU header pointer #1037

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Fix the target location of the FU header pointer #1037

merged 1 commit into from
Nov 17, 2023

Conversation

melpon
Copy link
Contributor

@melpon melpon commented Nov 15, 2023

fragmentIndicator() returns a H265NalUnitHeader*, so fragmentIndicator() + H265_NAL_HEADER_SIZE results in a 4-byte offset.

paullouisageneau
paullouisageneau approved these changes Nov 17, 2023
View reviewed changes
Copy link
Owner

@paullouisageneau paullouisageneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you for the fix

@paullouisageneau paullouisageneau merged commit be54edb into paullouisageneau:master Nov 17, 2023
11 checks passed
paullouisageneau added a commit that referenced this pull request Nov 20, 2023
@paullouisageneau
Merge pull request #1037 from melpon/fix-h265-fu-header
a37fa4b 
Fix the target location of the FU header pointer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paullouisageneau paullouisageneau paullouisageneau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melpon @paullouisageneau